Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1044
Upgrades Electron and Spectron by 3 major versions. Also of note, is the underlying webdriverio dep is upgraded by 2 major versions (4.xx -> 6.xx).
Here are some of the breaking changes:
Electron
remote
module is disabled by default now, and must be explicitly enabled for each browser window, this module is flagged to be deprecated and moved. More information on it's proposed future here.serialize()
anddeserialize()
methods to classes when we have to send them over the ipc wire. This is also a useful pattern for persisting app state, since we encounter the same problem there.Spectron
root
user inside our CI container.webdriverLogPath
if it didn't exist but the current version does not, now we create it ourselvesWebdriverio (provides the primary api we use to programmatically interact with a browser)
await apiMethod()
instead of using our own retry layers. Though this is not always the case.browser.method(selector, methodOptions)
->browser.$(selector).method(methodOptions)
in terms of the method input pattern. Since we are usingasync
mode, this also means each method must be awaited/handled as a promise.