Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e ingest test broken by move of Run button #2534

Closed
philrz opened this issue Sep 14, 2022 · 0 comments · Fixed by #2541
Closed

e2e ingest test broken by move of Run button #2534

philrz opened this issue Sep 14, 2022 · 0 comments · Fixed by #2541
Assignees
Labels
test Creating/improving test automation

Comments

@philrz
Copy link
Contributor

philrz commented Sep 14, 2022

A failed attempt by our CI to advance Brim's Zed pointer reveals that the e2e ingest tests started breaking as of the merge of #2530. I was able to repro a consistent failure by running yarn e2e locally at Brim commit 124d658. A failure looks like:

1) ingest.spec.ts:50:5 › Ingest tests › query000: "* | count()" ==================================

    Test timeout of 30000ms exceeded.

    locator.click: Target closed
    =========================== logs ===========================
    waiting for selector "div[aria-label="editor"] + button"
    ============================================================

      49 |     const testId = sprintf("%03d", i)
      50 |     test(`query${testId}: "${zed}"`, async () => {
    > 51 |       await app.query(zed)
         |       ^
      52 |       const resultStats = await app.getViewerStats()
      53 |       expect(resultStats).toEqual(expectedStats)
      54 |     })

        at TestApp.query (/home/runner/work/brim/brim/packages/e2e-tests/helpers/test-app.ts:71:69)
        at /home/runner/work/brim/brim/packages/e2e-tests/tests/ingest.spec.ts:51:7

Looking closer at the test code, I can see that points to:

https://github.com/brimdata/brim/blob/124d658befab6d03d047a9617552fa291d2bb283/packages/e2e-tests/helpers/test-app.ts#L69-L73

So, it appears that middle await is still expecting to find the Run button in the editor, but it's been moved to the title bar.

@philrz philrz added the test Creating/improving test automation label Sep 14, 2022
@philrz philrz assigned philrz and unassigned jameskerr Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Creating/improving test automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants