Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Design Update #2530

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Pin Design Update #2530

merged 4 commits into from
Sep 14, 2022

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Sep 12, 2022

The new pin button is moved right next to where the pins go. The "Run" button is moved to the Title Bar.

image

CleanShot.2022-09-12.at.15.45.20.mp4

Closes #2386
Fixes #2484

@jameskerr jameskerr requested a review from philrz September 12, 2022 22:52
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems like a great improvement, so a functional 👍 from me!

This doesn't have to be something that's added right now, but seeing these changes made me think again of the yellow highlighting pulse you added on the word "History" when the user hit the clock icon when the History panel was already open (#2518). Would it be feasible to add a similar yellow pulse effect to the dotted/placeholder "from" pin area when an "Error: pool name missing" comes up? Granted, this is really only a concern for users getting the hang of this for the first time. I'm mostly just concerned about users that were accustomed to the old workflow and wanting to give them the easiest possible time understanding the importnace of the "from" pins now.

@jameskerr jameskerr merged commit 124d658 into main Sep 14, 2022
@jameskerr jameskerr deleted the pin-update branch September 14, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Pins" menu is empty when accessed via >>> Make pin management closer to the pins
2 participants