Clicking History entry for deleted Space causes loss of context for current Space

[philrz]

When reviewing post-merge state of the functionality in #547, @alfred-landrum noted:

The rationale for keeping the history entries was to allow the user store them & run them again in live space. I don’t think we should try launch the search on the non-existent space.

Indeed, here's an example of an undesirable side-effect of the current behavior that feels like a bug. When I click on a History entry associated with a deleted Space, in addition to the error messages (which seem fine) it resets the app's context away from the Space I was looking at, which I found quite jarring as a user.

Video: repro.zip

[philrz]

Thanks to some other recent work, this has become a non-issue. We now maintain separately-tracked History entries for each Space. Therefore when a Space gets deleted, its History entries get taken out with it and there's no risk of clicking on such old entries anymore.

Closing!