PROD-1685 show warning in history if space deleted #547
Conversation
There was a problem hiding this comment.
Thanks Mason. A few suggested changes:
- The styles that are being applied to the svg icon are not specific enough and are being applied to the other svg (the close X on the tree view). By the way, this may have already been in master, but I figure here is a good place to fix it.
That margin right is causing the x to be misplaced in the tree view:
-
Add a class to the component that is wrapping the icon (that will allow you to target just that svg and fix the above error).
-
Try to make the icon sit vertically centered with the other elements in the row.
To do this, make sure that the parent elements all have display: flex; align-items: center and so does the class that you give to the element that wraps the icon.
It looks like some of the elements have a margin-bottom: 3px. You may need to add that to the icon-wrapper to get them centered vertically.
- I think the icon looks a little big right now. Maybe 11px height and width?
src/js/components/FilterTree.js
Outdated
| </div> | ||
| ) | ||
|
|
||
| if (!includes(spaces, findingSpace)) return body |
There was a problem hiding this comment.
Why not move this check to right under line 59 and return null early before creating the body variable. A few less CPU cycles.
| @@ -130,6 +130,7 @@ | |||
| "react-measure": "^2.3.0", | |||
| "react-redux": "^7.1.3", | |||
| "react-spring": "^8.0.27", | |||
| "react-tooltip": "^4.1.3", | |||
| @@ -130,6 +130,7 @@ | |||
| "react-measure": "^2.3.0", | |||
| "react-redux": "^7.1.3", | |||
| "react-spring": "^8.0.27", | |||
| "react-tooltip": "^4.1.3", | |||
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Shows a warning⚠️ symbol next to history entries which no longer have their corresponding space. Related work that I've included here is importing the react-tooltip component as well as making sure that the tree logic for loading past history items behaves the same way that linear history does. Previously it would only load the search entry in whatever tab/space you already have open, and throw an error if nothing was open yet.