Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations not working from v0.8.0 #815

Closed
philrz opened this issue May 26, 2020 · 1 comment · Fixed by #823
Closed

Migrations not working from v0.8.0 #815

philrz opened this issue May 26, 2020 · 1 comment · Fixed by #823
Assignees
Labels
bug Something isn't working
Milestone

Comments

@philrz
Copy link
Contributor

philrz commented May 26, 2020

I've only focused on Brim GA tag v0.8.0 for this specific repro, but after talking to @jameskerr it sounds like this is a general issue with migrations not having been considered for "from" releases other than GA tag v0.9.1.

In the attached video, I started out running v0.8.0, import a small pcap, then perform a couple queries to populate my History. I then close the app and upgrade to a release artifact based on Brim commit dc488b1. On the first launch into the app, other than a "Failed to fetch" message that I had to Dismiss, it looks as if maybe it cleared all app state, which might be an appropriate thing to do in this situation. However, when I close the app yet again and reopen, now I see ghostly remnants of my prior Space: A nameless entry in the Recent Spaces list, empty "star" entries in the History panel, etc.

Repro.mp4.zip

@philrz philrz added the bug Something isn't working label May 26, 2020
@philrz philrz added this to the Brim v0.10.0 milestone May 26, 2020
@jameskerr jameskerr self-assigned this May 27, 2020
@philrz philrz linked a pull request May 28, 2020 that will close this issue
@philrz
Copy link
Contributor Author

philrz commented May 29, 2020

Verified in Brim commit 9373ee8. In the attached video, I'd already performed the repro steps in v0.8.0 to have a populated search history, but now upgrade to a new release artifact based on commit 9373ee8. As shown, now my History entries are cleared out, indicating the state has been reset as promised in the linked PR. However, my Space is still present, and I can run queries against it and it starts to re-populate my History. Since the original bug also showed different behaviors between repeated app launches, I did that here as well and everything was still healthy after the extra close & relaunch.

Verify.mp4.zip

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants