Reset state if less than v0.9.1 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures here look like brimdata/super#613 |
|
I believe this zq PR: brimdata/super#826 will address the blank space names. |
mason-fish
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has a version prior to v0.9.1, we don't try to migrate their state.
If you open the app in v0.8.0, ingest some data, perform some searches, then quit, then open the app at master, you'll see a message in the logs that says:
It will indeed clear the state and start fresh. However, the spaces that you ingested will remain.
Known Bug With Space Names
Testing this revealed a bug in zqd. The spaces created in v0.8.0 (before space ids), are returned without a name after upgrading to the latest brim version. It results in the app looking like this when you load up the newest version.
In this example, I ingested a file called
a.pcapin v0.8.0, then quit, upgraded, and re-opened brim.Work on the zqd migration is being tracked in brimdata/super#791