query annotation and test fixes #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <mason@brimsecurity.com>
mason-fish
force-pushed
the
1835-date-bug
branch
from
35a7ac6 to
a867939
Compare
Signed-off-by: Mason Fish <mason@brimsecurity.com>
nwt
approved these changes
Sep 15, 2021
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1835
The problem with the missing
0s we see in the indeterminate test is not the backend, it is thedateToNanoTsfunction. It's not entirely a problem so much as an inconsistency:The current default behavior is to not include trailing
0s, which is an acceptable format for the timestamp as the backend parses it. In our tests, we use the date.toISOString()method to compare expected values, and that method always includes the full millisecond width, which revealed the formatting difference.The fix I'm proposing here then is to ensure the decimal width returned by
dateToNanoTsis at least the full ms, trailing zeros or not, while µs and ns widths may vary by trailing zeros.Also proposed here is a temporary workaround for the query annotator, as discussed with @nwt: If a query looks like it begins with any sort of
fromthen we will NOT annotate it at all and just pass it on as is to the request. This way we can expose the feature of querying from multiple pools while still supporting the existing/expected search behavior. Ultimately, we should discuss the "pool search" vs "lake search" (searching across multiple pools in a lake) workflows a bit more to come up with a better solution for this.Signed-off-by: Mason Fish mason@brimsecurity.com