Improve brimcap analyze error handling #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <mason@brimsecurity.com>
jameskerr
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1820
When we load a pool with the brimcap plugin, we pass each specific load operation the output stream from a forked
brimcap analyzeprocess. If the analyze process fails the load operation will fail too, but we have not been handling the load and/or analyze errors properly. This PR aims to fix that: now if load fails, we will check for an analyze error and report that if it exists, otherwise we report the load error.I think this is also a bit cleaner to use a single error flag,
analyzeErrthat is a dedicated error bucket for the analyze operation, as opposed to a general error bucket for the analyze, load, and index operations.Signed-off-by: Mason Fish mason@brimsecurity.com