Stop Wasted Renders When Typing Search #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the search bar was responding very slowly when the app was in some states. I opened the react devtools and told it to highlight elements that re-render. Following the trail I was able to significatly improve performance by not needlessly rendering things.
jameskerr
force-pushed
the
performance-fix
branch
from
c60b27b to
c4ebf95
Compare
The state to props function is run even when the component is about to unmount. This caused a bug where the component depends on the pool being set. When it was unmounting, it was not.:wq
mason-fish
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the search bar was responding very slowly when the app was in some states. I opened the react devtools and told it to highlight elements that re-render. Following the trail I was able to significantly improve performance by not needlessly rendering things.
Before
After