Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix useLocation delay #1897

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fix useLocation delay #1897

merged 2 commits into from
Oct 26, 2021

Conversation

mason-fish
Copy link
Contributor

@mason-fish mason-fish commented Oct 25, 2021

fixes #1869

This one was quite tricky! With some components looking at the react-router in memory history, and some looking at the global tabHistories, we ran into some sync issues. Changes here focus on only using the Current.getLocation in our components, and refactoring the url change redux "tree shaking" so that it is all handled in one place.

Signed-off-by: Mason Fish mason@brimsecurity.com

Signed-off-by: Mason Fish <mason@brimsecurity.com>
@mason-fish mason-fish force-pushed the 1869-fix-chart-viewer-sync branch from 8c6985a to 10d219f Compare October 25, 2021 20:11
Signed-off-by: Mason Fish <mason@brimsecurity.com>
@mason-fish mason-fish force-pushed the 1869-fix-chart-viewer-sync branch from 10d219f to e019fda Compare October 25, 2021 20:12
@mason-fish mason-fish marked this pull request as ready for review October 25, 2021 20:18
@mason-fish mason-fish requested a review from a team October 25, 2021 20:18
@mason-fish mason-fish merged commit 2d918c2 into main Oct 26, 2021
@mason-fish mason-fish deleted the 1869-fix-chart-viewer-sync branch October 26, 2021 13:37
@mason-fish mason-fish linked an issue Oct 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart out of Sync With Viewer
2 participants