Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "Add Workspace..." to "Add Lake..." #1957

Merged
merged 2 commits into from
Nov 13, 2021
Merged

change "Add Workspace..." to "Add Lake..." #1957

merged 2 commits into from
Nov 13, 2021

Conversation

mccanne
Copy link
Contributor

@mccanne mccanne commented Nov 13, 2021

This is an incomplete fix for issue #1922 but we are getting this
small change in now to immediately improve the cloud onboarding
terminology. This will create some inconsistency in the docs that
refer to Workspace instead of Lake and throughout the code until
issue #1922 is addressed, but that should happen soon.

This is an incomplete fix for issue #1922 but we are getting this
small change in now to immediately improve the cloud onboarding
terminology.  This will create some inconsistency in the docs that
refer to Workspace instead of Lake and throughout the code until
issue #1922 is addressed, but that should happen soon.
Signed-off-by: Mason Fish <mason@brimsecurity.com>
Copy link
Contributor

@mason-fish mason-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a few more of the user facing instances of "workspace"

@mccanne mccanne merged commit 5c7f966 into main Nov 13, 2021
@mccanne mccanne deleted the add-lake branch November 13, 2021 17:56
@mattnibs
Copy link
Contributor

Verified this works as of v0.28.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants