Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save scroll position #2271

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Save scroll position #2271

merged 2 commits into from
Mar 14, 2022

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Mar 10, 2022 •
edited
Loading

The scroll position is now saved when you switch back and forth between the inspector and the viewer.

Screen.Recording.2022-03-10.at.1.13.46.PM.mov

TODO:

  • Make sure this works in the query flow code as well.

Closes #2218
Closes #2270

@jameskerr jameskerr requested a review from mason-fish March 10, 2022 21:13
mason-fish
mason-fish approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@mason-fish mason-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on! 👍

@jameskerr jameskerr merged commit 62214f3 into main Mar 14, 2022
@jameskerr jameskerr deleted the scroll-position branch March 14, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mason-fish mason-fish mason-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Key Issue in Inspector Save Scroll Position
2 participants
@jameskerr @mason-fish