Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix about window #2347

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix about window #2347

merged 1 commit into from
May 4, 2022

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented May 4, 2022 •
edited
Loading

The about window was not working because we were looking for the wrong div id in the html.

Fixes #2332

@jameskerr jameskerr requested a review from mason-fish May 4, 2022 17:38
mason-fish
mason-fish approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@mason-fish mason-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Nice catch

@jameskerr jameskerr merged commit 067040b into main May 4, 2022
@jameskerr jameskerr deleted the fix-about-window branch May 4, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mason-fish mason-fish mason-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"About" window no longer works (regression at 798e664)
2 participants
@jameskerr @mason-fish