fix zdeps -version output with dummy @yarnpkg/plugin-github #2349
Conversation
.github/workflows/advance-zed.yml
Outdated
| # The "git@github.com:" prefix causes Yarn to clone the repository | ||
| # rather than fetch a tarball. This ensures "zed -version" and | ||
| # "zq -version" produce meaningful output. | ||
| - run: yarn add zed@git@github.com:brimdata/zed#${{ steps.zed_pr.outputs.sha }} |
There was a problem hiding this comment.
I'm not sure about relying on ssh git, as it feels like github is slowly trying to get rid of it.
There was a problem hiding this comment.
I forgot that SSH authentication won't work in CI without some fiddling, so I went in a different direction and disabled the @yarnpkg/plugin-github plugin.
(I don't think SSH is on the way out, though. Perhaps you're thinking of the git:// protocol, which they've already disabled?)
Both Brimcap and Zed must be built in a cloned Git repository to ensure that "brimcap -version", "zed -version", and "zq -version" produce meaningful output, but Yarn's @yarnpkg/plugin-github plugin fetches tarballs for GitHub respotories instead of cloning them. Add a dummy plugin so Yarn will clone repositories instead.
nwt
changed the title
nwt
changed the title
|
Because CI enables Yarn caching, this effect of this change won't be visible until the next bump of Brimcap and Zed. You can see this working with the Yarn cache disabled at https://github.com/brimdata/brim/runs/6313928920?check_suite_focus=true#step:6:769. |
That's certainly possible, though at present Brimcap and Zed are the only two GitHub repository dependencies in |
Both Brimcap and Zed must be built in a cloned Git repository to ensure
that "brimcap -version", "zed -version", and "zq -version" produce
meaningful output, but Yarn's @yarnpkg/plugin-github plugin fetches
tarballs for GitHub repositories instead of cloning them. Add a dummy
plugin so Yarn will clone repositories instead.
Closes #2311.