Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow hidden on the results #2513

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Overflow hidden on the results #2513

merged 1 commit into from
Sep 2, 2022

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Sep 1, 2022

This must have happened in a merge conflict.

Fixes #2492

@jameskerr jameskerr requested a review from philrz September 1, 2022 22:04
@philrz philrz mentioned this pull request Sep 1, 2022
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this out on the branch and the fix indeed appears effective. Regarding its origin, it looks like this started life without the overflow: hidden; in https://github.com/brimdata/brim/pull/2439/files#r961143278 when that file was otherwise going through lots of changes. 🤷‍♂️

@jameskerr jameskerr merged commit ad6e064 into main Sep 2, 2022
@jameskerr jameskerr deleted the overflow branch September 2, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Scroll right" makes column headers bleed into pools list
2 participants