Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on Enter Preference #2573

Merged
merged 6 commits into from
Nov 6, 2022
Merged

Run on Enter Preference #2573

merged 6 commits into from
Nov 6, 2022

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Oct 26, 2022

If the setting is set to true, enter runs the query, shift+enter gives a new line.

If the setting is false, cmd+enter runs the query and enter gives a new line.

CleanShot 2022-10-25 at 17 21 02@2x

Closes #2451

@jameskerr jameskerr requested a review from philrz November 4, 2022 23:07
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this branch at commit a470f02 and everything is working as I'd expect. On Windows and Linux, when the box was unchecked, Ctrl+Enter was now used to execute the queries, and on macOS it was Cmd+Enter. Therefore it's a functional 👍 from me.

@philrz philrz merged commit 9194bc8 into main Nov 6, 2022
@philrz philrz deleted the run-on-enter branch November 6, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve editor UX for adding additional lines of Zed
2 participants