Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode JSON Strings in Headers #2744

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Encode JSON Strings in Headers #2744

merged 3 commits into from
Mar 31, 2023

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Mar 30, 2023 •
edited by philrz
Loading

I did some acciental git --ammend so the commits are weird. But the code is good.

Here's the failing test before making the needed changes to escape the header json object.

Screenshot 2023-03-30 at 4 38 54 PM

The fix is to use this trusty code snippet on stack overflow! https://stackoverflow.com/a/40347926

Fixes #2723

@jameskerr jameskerr requested review from nwt and philrz March 30, 2023 23:46
philrz
philrz approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out well for me and the changes makes sense. 👍

@jameskerr jameskerr merged commit f835e04 into main Mar 31, 2023
@jameskerr jameskerr deleted the jameskerr/issue2723 branch March 31, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz approved these changes

@nwt nwt Awaiting requested review from nwt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zui import error when file path contains Chinese and other wide characters
3 participants
@jameskerr @philrz @nwt