Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Error || Result Error #3065

Merged
merged 11 commits into from
May 7, 2024
Merged

Parse Error || Result Error #3065

merged 11 commits into from
May 7, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented May 2, 2024

When choosing what to render in the results panel, the app will prefer the parse error from the /compile endpoint over the error returned from the /query endpoint.

This fixes #3051

  • Add View Handler
  • Add State Object
  • Initialize The View Handler Context
  • Add Bullet Module
  • Move to SessionPageHandler
  • Render the parse errors first

@jameskerr jameskerr requested review from mattnibs and philrz May 2, 2024 18:58
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've black box tested the branch and the change seems effective. I looked over the code and nothing looks particularly scary to me. I'm fine with this merging once the current lint error is addressed. 👍

@philrz philrz merged commit f7727f3 into main May 7, 2024
3 checks passed
@philrz philrz deleted the query-error-messages branch May 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed parser errors showing non-user code
2 participants