-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor Error Markers #3087
Editor Error Markers #3087
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi all, I've fixed the error in the source set code in the last commit. I was adding the pipe at the wrong moment. @mattnibs You're right that there is some duplication. The error markers are shown as the user types. Not when they press enter to submit the query. During the time they've modified the query but not yet submitted it, they'll only see the red markers. Once they press enter, they will see the error in the results view. I think this is better than displaying nothing in the results error. So I think we should leave this as is for now. Here's a video showing the current behavior: CleanShot.2024-06-12.at.10.48.37.mp4 |
Markers in the editor when the query contains errors.