Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface Export Errors #3115

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Surface Export Errors #3115

merged 6 commits into from
Jun 26, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Jun 25, 2024 •
edited by philrz
Loading

A toast error will now appear if there was a problem with the export.

CleanShot 2024-06-25 at 16 44 12@2x

Fixes #2751

@jameskerr jameskerr requested a review from philrz June 25, 2024 23:45
philrz
philrz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

In addition to witnessing the fix with CSV data, I also revived my Parquet changes referenced in #2591 and saw it addressed that too. So once this merges I'll be putting up a PR to support a new Export format. 😉

@jameskerr jameskerr merged commit 67e53f7 into main Jun 26, 2024
4 checks passed
@jameskerr jameskerr deleted the export-errors branch June 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query runtime errors are not being surfaced
2 participants
@jameskerr @philrz