Change guidance that mentions fuse when there's multiple shapes #3150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
When results contain multiple shapes, I'm proposing changing the wording of the guidance in the default Table view to:
Details
This is one that hit me when I was testing the changes in #3145.
Right now when the results contain multiple shapes, the default Table view shows the guidance:
This guidance is accurate if the data happens to be records, which it often is. However (and maybe this is spitting hairs), if the data contains one or more primitive values, such as this ZSON test data:
the guidance becomes inaccurate because even if the user does apply
fuse
, the data shown is still not in a "table" in the traditional sense because there's no header containing a field name. Rather, the data is instead still just a sequence of values, though nowfuse
has applied a union type to all of them such that the user is, indeed, now looking at a single shape.Therefore, in this PR I've proposed adjusting the guidance to instead say:
since this seems to cover all cases in a technically accurate way.
(Thanks to @nwt for the proposed wording!)
(Really, I think the most important part of this guidance has always been giving the user the one-click access to
fuse
, since this is probably what users are looking for much of the time, but new users in particular are unlikely to immediately read through the Zed docs and find it right off the bat. All that is still fully intact with this change, so hopefully it's non-controversial.)