Do not mutate the window state object #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
commented
Apr 14, 2020
|
|
||
| store.dispatch(saveWindowState()) | ||
|
|
||
| expect(store.getState()).toEqual(prevState) |
There was a problem hiding this comment.
Before the fix above, this would fail with the "errors" "notice" and "handlers" keys missing.
mattnibs
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
This caused a strange bug where
state.handlerswas undefined. Then the app tried to do something with it, and it threw an error. I traced it back to this state mutation.It's now locked in with a unit test