Load Files Input UI #625
Merged
Load Files Input UI #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
force-pushed
the
ingest-design
branch
4 times, most recently
from
18e03df to
f7f8eed
Compare
mikesbrown
reviewed
Apr 21, 2020
There was a problem hiding this comment.
@jameskerr Care to add some integration tests that ingest itest/sample.{ndjson,tsv}? A lot of what you already need should be available for direct use, or useful as example. You may modify or copy-from-example pcapIngestSample() to ingest the NDJSON and Zeek TSV. The test pcap ingest in itest/test/smoke.js is a fine example to follow for the actual tests.
Comment on lines
+113
to
+116
| ingest: { | ||
| filesInput: dataAttrSelector("ingestFilesInput"), | ||
| filesButton: dataAttrSelector("ingestFilesButton") | ||
| }, |
There was a problem hiding this comment.
Thanks for being mindful of good naming!
mason-fish
approved these changes
Apr 21, 2020
| @@ -0,0 +1,27 @@ | |||
| /* @flow */ | |||
There was a problem hiding this comment.
Oh fun! I was just thinking about how useful a generator like this would be as I added in the expand icon recently 👏
|
@mikesbrown I'd be happy to write an integration test. Thanks for the suggestion. |
Based on PcapInput component
Since the file input is now a permanently hidden element, wait for the button to appear, but still use the input.
I have lots of unit tests that catch edge cases, so I feel good with just this one.
jameskerr
force-pushed
the
ingest-design
branch
from
2ae6d90 to
b861960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #572
It now looks like so:
With an animation that looks like this.
This PR is the html and style changes, but the PR #594 contains the functionality. That one must be merged first.