Custom types config #719
Merged
Custom types config #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-fish
approved these changes
May 1, 2020
| css rule of pointer-events: none. | ||
| */ | ||
|
|
||
| export default function useDropzone(dropCallback: Function) { |
If you throw an object in the constructor of Error, it will call toString on it resulting in the error message being "[Object object]" which sucks. If zqd returned json, just throw that json object.
This clears out any bad state we may have when things fail. Also console log the error here so that we can debug things easier if ingest failures happen.
jameskerr
force-pushed
the
custom-types-config
branch
from
63cfc9f to
4beb940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #694
Adds a global user preference for which JSON type config file the app should use when ingesting json files. If it is empty, then we use the default provided within the app. Otherwise, we read the contents of that file each time we ingest, and send it over in the payload of our POST /logs/ request.
Of interest:
Providing a custom types.json and ingest a custom ndjson file
A little bit of validation (check if the file exists and if its json)
What happens when you select a garbage file as your types_config