Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car interference #47

Merged
merged 25 commits into from
Jan 29, 2024
Merged

Car interference #47

merged 25 commits into from
Jan 29, 2024

Conversation

JanHodic
Copy link

@JanHodic JanHodic commented Apr 5, 2023

PostgreSQL able to connect, collation removed

JanHodicBringauto and others added 7 commits March 22, 2023 14:29
* BAIP-143 (solved)

* paste in to text fields fixed

* Update RunTestEnvironment.md

* minor changes

* coordinates validation (in progress)

* Minor changes

* added recenter button (still needs some css changes)

* Added delete confirmation (car deletion, station deletion, route deletion) + added css to recenter button (still requires some work)

* eslint warnings resolved

* Editation dialog modified + minor changes

* packages updated

* Leaflet attribution removed

* Removed console logs and other debugging tools, fixed some minor things in positionHelpers

* package fix

* package fix

* node 16 -> node 20

* Update TeleopCard.vue

* Fixed "Code smell"

[HttpPost("startstop")]
[AllowAnonymous]
public async Task<ActionResult<Car>> StartStopCar(string companyName, string carName, CarStatusInfo aaaa)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is thjs part of the code?

from: new Twilio.Types.PhoneNumber(options.Value.FromNumber),
to: new Twilio.Types.PhoneNumber(number)
);
for (int i = 0; i < 5; i++)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is purpose of this code block?

@@ -50,5 +59,25 @@ public Task Call(string number, string messageUri)
}
return Task.CompletedTask;
}

private static bool WaitForCallPickup(String sid)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

@MarioIvancik MarioIvancik merged commit 4751a9e into main Jan 29, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MarioIvancik MarioIvancik deleted the CarInterference branch March 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants