Skip to content

Commit

Permalink
Typos and documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
mikusaq committed Oct 16, 2024
1 parent b07b8c1 commit d7059de
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
5 changes: 2 additions & 3 deletions bap-builder/DockerMode.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ func BuildDockerImage(cmdLine *BuildImageCmdLineArgs, contextPath string) error
if err != nil {
return err
}
buildSingleDockerImage(*cmdLine.Name, dockerfilePath)
return nil
return buildSingleDockerImage(*cmdLine.Name, dockerfilePath)
}

// buildAllDockerImages
Expand All @@ -42,7 +41,7 @@ func buildAllDockerImages(contextManager ContextManager) error {
logger.Warn("Bug: multiple Dockerfile present for same image name %s", imageName)
continue
}
buildSingleDockerImage(imageName, dockerfilePath[0])
return buildSingleDockerImage(imageName, dockerfilePath[0])
}
return nil
}
Expand Down
3 changes: 3 additions & 0 deletions modules/bringauto_docker/DockerTools.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import (
"strconv"
)

// IsDefaultPortAvailable
// Returns true if default port for docker is available, else returns false.
// When false is returned, the error contains message from the docker command.
func IsDefaultPortAvailable() (bool, error) {
var outBuff, errBuff bytes.Buffer

Expand Down
8 changes: 4 additions & 4 deletions modules/bringauto_process/SignalHandler.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ func removeLastHandler() {

func executeAllHandlers() {
for i := len(handlers)-1; i >= 0; i-- {
err := handlers[i]()
if err != nil {
bringauto_log.GetLogger().Error("Handler returned error - %s", err)
}
err := handlers[i]()
if err != nil {
bringauto_log.GetLogger().Error("Handler returned error - %s", err)
}
}
}

0 comments on commit d7059de

Please sign in to comment.