-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to fileSystemRouter
to be more runtime-agnostic
#386
Conversation
note: there was a bug in 0.0.159-canary.1, fixed in 0.0.159-canary.4, try this one better. |
a14c481
to
6aabf28
Compare
@aralroca I ran If I go back to brisa By the way, I checked the hot reloading again, and I can confirm what you mentioned here. It always breaks upon the second hot-reload. |
Thanks for the feedback, try canary.4, it should work now! |
With |
Hot reloading in Windows is for that Bun crash issue: oven-sh/bun#13089 😣 But something else unrelated to this PR |
Fixes #304
Fixes #390
Related with #195
Related with #318
I have migrated
Bun.FileSystemRouter
for our ownfileSystemRouter
implementation. The API is the same, but there are some differences:Bun.FileSystemRouter
and had been fixed.As a curiosity, it is faster than
Bun.FileSystemRouter
🙃Please @AlbertSabate @adriablancafort @gariasf confirm if this 0.0.159-canary.4 canary version works for you (before merging this PR) to know that it continues to work in Windows correctly and in your environments and if everything is OK.
P.S: @leerob This change opens the door for the
adapter-vercel
to go beyond static.