fix: fix crash on Node.js for Intl.Locale variation #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
commented
Aug 27, 2024
| @@ -27,7 +32,7 @@ const staticExportOutputOption = new Set([ | |||
| const srcDir = path.resolve(rootDir, 'src'); | |||
| const buildDir = | |||
| process.env.BRISA_BUILD_FOLDER ?? path.resolve(rootDir, 'build'); | |||
| const WORKSPACE = IS_SERVE_PROCESS ? buildDir : srcDir; | |||
| const WORKSPACE = IS_BUILD_PROCESS ? srcDir : buildDir; | |||
There was a problem hiding this comment.
We only need src building the app, otherwise is always from the build folder. Similar than before, but better, because with a Custom Server is "serve" but was detected as "build", now is better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #195
Related #318
Tot get the direction, in Node is
new Intl.Locale(locale).textInfo.directionand in Bun isnew Intl.Locale(locale).getTextInfo().direction, the second one replaces the first one, but we need to support both if we want to support Node.js