Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Node.js as output #441

Merged
merged 47 commits into from
Aug 31, 2024
Merged

feat: support Node.js as output #441

merged 47 commits into from
Aug 31, 2024

Conversation

aralroca
Copy link
Collaborator

@aralroca aralroca commented Aug 30, 2024

WIP

Fixes #442
Fixes #195
Related #318

TODO:

  • i18n is not working properly
  • Check that redirects work correctly (trailing slash, etc.)
  • RPC on navigation is not working correctly (issue with req.body)
  • openEditor should not be called if the runtime is not Bun
  • Server actions are not working
  • Suspense is not working (u$ is not defined) - It’s an issue with VERSION_HASH between bun devandbun symlink`
  • Test API routes
  • Capture errors from the handler without crashing Node.js
  • Investigate the output of Svelte/Astro's adapterNode, do they modify the output? What does it do?
  • If output="node", build with Node target.
  • Facilitate Custom Server + documentation
  • Make bun start work with Node.js
  • During the build, if it's Node, place server.js in build/server.js (constants should be hardcoded)
  • Add documentation for handler and serve to API references
  • Add tests for node handler. For now, I've added the first one, but the following are pending:
    • Fix the pipeline to pass this simple test
    • Fix the pipeline to see why so many Bun.js tests are failing now; it was cleaner before (8 Mac, 41 Linux)
    • Fix Windows test absolute path with file://
    • Add more tests to the handler, value tests, not just the simple proof-of-concept test
  • Fix cookie handling
  • add cert and key from config
  • Document about WebSockets

@aralroca aralroca changed the title feat: support Node as output feat: support Node.js as output Aug 30, 2024
@aralroca aralroca force-pushed the aralroca/add-node-output branch from 32542ba to f8a0d09 Compare August 30, 2024 12:05
@aralroca aralroca force-pushed the aralroca/add-node-output branch from f8a0d09 to 0431cf9 Compare August 31, 2024 08:09
@aralroca aralroca marked this pull request as ready for review August 31, 2024 22:44
@aralroca aralroca merged commit c04bf79 into main Aug 31, 2024
3 of 6 checks passed
@aralroca aralroca deleted the aralroca/add-node-output branch August 31, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add serve and handler to serve Node.js Brisa app output to node (Node.js) to be more runtime-agnostic
1 participant