-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Node.js as output #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
changed the title
feat: support Node as output
feat: support Node.js as output
Aug 30, 2024
aralroca
force-pushed
the
aralroca/add-node-output
branch
from
August 30, 2024 12:05
32542ba
to
f8a0d09
Compare
aralroca
force-pushed
the
aralroca/add-node-output
branch
from
August 31, 2024 08:09
f8a0d09
to
0431cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #442
Fixes #195
Related #318
TODO:
req.body
)openEditor
should not be called if the runtime is not Bunu$ is not defined) - It’s an issue with VERSION_HASH between
bun devand
bun symlink`adapterNode
, do they modify the output? What does it do?output="node"
, build with Node target.bun start
work with Node.jsserver.js
inbuild/server.js
(constants should be hardcoded)handler
andserve
to API referenceshandler
. For now, I've added the first one, but the following are pending: