Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Makefile and add Live Reloading #68

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Get rid of Makefile and add Live Reloading #68

merged 5 commits into from
Feb 27, 2019

Conversation

rauanmayemir
Copy link
Member

@rauanmayemir rauanmayemir commented Feb 15, 2019 •
edited
Loading

This PR's scope has changed a bit, so it covers the following:

  • Get rids of the Makefile, moving all the flow control to dune (Closes Get rid of the Makefile for components-macos example #45)
  • Streamlines the execution flow because now we can configure all the flags with pkg-config
  • Improves the workflow to be used with dune's watch mode. Running esy watch will rebuild and rerun the app. (this is not hot reloading yet)

@rauanmayemir rauanmayemir added the macOS macOS renderer label Feb 15, 2019
@rauanmayemir rauanmayemir changed the title Component examples app Get rid of Makefile and add a watch mode Feb 26, 2019
@wokalski wokalski changed the title Get rid of Makefile and add a watch mode Get rid of Makefile and add Live Reloading Feb 26, 2019
wokalski
wokalski approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@wokalski wokalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and I love the changes. Make sure to add a gif 😄.

examples/components-macos/app/dune Outdated Show resolved Hide resolved
examples/components-macos/app/dune Outdated Show resolved Hide resolved
examples/components-macos/app/dune Outdated Show resolved Hide resolved
examples/components-macos/app/project.yml Show resolved Hide resolved
examples/components-macos/app/project.yml Outdated Show resolved Hide resolved
@rauanmayemir rauanmayemir force-pushed the feature/components-app branch 4 times, most recently from c304be2 to 9551f57 Compare February 26, 2019 18:28
@rauanmayemir rauanmayemir marked this pull request as ready for review February 26, 2019 18:43
@wokalski wokalski merged commit 7763e73 into master Feb 27, 2019
@wokalski wokalski deleted the feature/components-app branch February 27, 2019 05:05
@rauanmayemir rauanmayemir mentioned this pull request Feb 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wokalski wokalski wokalski approved these changes

Assignees
No one assigned
Labels
macOS macOS renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauanmayemir @wokalski