-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow up of issue #67, #69 #84
Comments
When you enter your variant, do you see the warning described in |
Yes, I do. So I want to check if the delta score is due to the technical artefact or not. How do I check?
Thanks a lot
Huilin
From: Ben Weisburd ***@***.***>
Sent: 08 November 2024 15:07
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
When you enter your variant, do you see the warning described in
#69<https://scanmail.trustwave.com/?c=8248&d=5amu5x0g0Nwbp0YJaeiY4i5EXwOHmP9APw-JkuoiOA&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f69> ?
image.png (view on web)<https://scanmail.trustwave.com/?c=8248&d=5amu5x0g0Nwbp0YJaeiY4i5EXwOHmP9APwmNlrAkaQ&u=https%3a%2f%2fgithub%2ecom%2fuser-attachments%2fassets%2fd01e4ef8-dd0d-4ad0-9d3f-cf0e62997ecb>
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=5amu5x0g0Nwbp0YJaeiY4i5EXwOHmP9APwrYl7RzaQ&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2464989850>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=5amu5x0g0Nwbp0YJaeiY4i5EXwOHmP9APw2JmOQlPQ&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQOGJW3KRTMGUHZO5TY3Z7THRDAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUHE4DSOBVGA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
I was thinking of adding a table like the example in ![]() Do you agree a table like this would address your question? |
Yes definitely. The reason I raised this issue here is to get a table like that. Is it possible for SpliceAi provide the table automatically with a link in the cases like this?
Thanks a lot
Huilin
From: Ben Weisburd ***@***.***>
Sent: 08 November 2024 18:11
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
I was thinking of adding a table like the example in
#69 (comment)<https://scanmail.trustwave.com/?c=8248&d=2tSu59z7LgSRTixRYsK6JxeVUz1ergswaiBp7EHrPg&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f69%23issue-2172730864>
image.png (view on web)<https://scanmail.trustwave.com/?c=8248&d=2tSu59z7LgSRTixRYsK6JxeVUz1ergswaiQ8tUuwPQ&u=https%3a%2f%2fgithub%2ecom%2fuser-attachments%2fassets%2f27d23f08-5f6a-4394-8660-7daaa506e5af>
Do you agree a table like this would address your question?
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=2tSu59z7LgSRTixRYsK6JxeVUz1ergswanU8tUHsaw&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2465466912>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=2tSu59z7LgSRTixRYsK6JxeVUz1ergswanU04UPpPw&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQOA2BZVAIDCA6S6WY3DZ7T5BRAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGQ3DMOJRGI>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
Hi Ben
Many thanks for your time. I like the table and it’s very helpful. But my question is actually how to generate this table for my own variant (chr6-56617985-C-CCT, hg38).
I was hoping this table would appear in SpliceAI along with the warning message, just like you did in the example.
KR
Huilin
From: Ben Weisburd ***@***.***>
Sent: 12 November 2024 14:11
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
I've now added this table to a popup for variants where the warning appears:
image.png (view on web)<https://scanmail.trustwave.com/?c=8248&d=o-Kz50ayB3atpdHKuOhl1y_uiYo18DT8y9UNJfRJXw&u=https%3a%2f%2fgithub%2ecom%2fuser-attachments%2fassets%2faca6ebb3-7afd-474c-812e-d7b2b9b675b9>
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=o-Kz50ayB3atpdHKuOhl1y_uiYo18DT8y9gKcKodXQ&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2470640789>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=o-Kz50ayB3atpdHKuOhl1y_uiYo18DT8y4xYcPROUA&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQOBW5LC3PURVRLHXJF32AIEAVAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQGY2DANZYHE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
It was showing cached results from before the feature was added. If you reload the page, you should see the new tables. |
Yes! That’s fabulous! Thanks a million. Will this table be added along with the warning message for other similar variants as well? I just don’t want to trouble you or other SpliceAI colleagues each time for the same query.
KR
Huilin
From: Ben Weisburd ***@***.***>
Sent: 12 November 2024 17:02
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
It was showing cached results from before the feature was added. If you reload the page, you should see the new tables.
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=3Yqz59HlSHnFzH7RwzsfbAG2Q_wKMgYQK91Gs3fVHg&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2471094148>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=3Yqz59HlSHnFzH7RwzsfbAG2Q_wKMgYQK94e4iTTHA&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQOEOXULV36TZFWK7RBT2AIYBLAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGA4TIMJUHA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
Hi Huilin, yes, the table appears for any variant that has that warning. |
Thanks a million!
Huilin
From: Ben Weisburd ***@***.***>
Sent: 13 November 2024 13:31
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
Hi Huilin, yes, the table appears for any variant that has that warning.
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=0Kq05xKO8y-fK3W_eNk7Mwa40Q3FLdqr0hcF1MRv2Q&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2473630191>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=0Kq05xKO8y-fK3W_eNk7Mwa40Q3FLdqr0kZQ05JhjQ&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQOGAL4ZYCZHDYUFM5732ANIBBAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTGYZTAMJZGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
Also, based on additional feedback, instead of the warning icon, we now just show the exact position in the main table, along with the icon that brings up the detailed table. [example] ![]() |
Hi,
When I tried to visualize the example indicated in your message below and clicked on the icon, I did see a table popping up on the bottom left but only partially. It seems that it does not properly fit on the screen of my laptop computer. Impossible to scroll further to the right.Difficult to inspect the full table even when I resize the screen
All best;
Alexandra
Le Mercredi, Novembre 13, 2024 22:30 CET, Ben Weisburd ***@***.***> a écrit:
Also, based on additional feedback, instead of the warning icon, we now just show the exact position in the main table, along with the icon that brings up the detailed table. [example]image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#84 (comment)", "url": "#84 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
--
Alexandra Martins, PhD, HDR
Inserm Researcher (CRHC)
Group Leader
Inserm UMR 1245 - Cancer and Brain Genomics
UFR Santé
22 Bvd Gambetta
CS 76183
76183 Rouen Cedex 1
France
phone#: + 33 (0)2 35 14 83 14
email: ***@***.***
https://www.researchgate.net/profile/Alexandra_Martins5
ORCID ID: 0000-0003-4322-8497
|
Hi Alexandra, what browser and operating system are you using? |
Hi Ben
The table is showing correctly on my laptop for my variant. I use google chrome. And I like the updated version “instead of the warning icon, we now just show the exact position in the main table, along with the icon that brings up the detailed table”!
Thanks a lot
Huilin
From: Ben Weisburd ***@***.***>
Sent: 14 November 2024 00:11
To: broadinstitute/SpliceAI-lookup ***@***.***>
Cc: Jin Huilin ***@***.***>; Author ***@***.***>
Subject: Re: [broadinstitute/SpliceAI-lookup] follow up of issue #67, #69 (Issue #84)
Hi Alexandra, what browser and operating system are you using?
—
Reply to this email directly, view it on GitHub<https://scanmail.trustwave.com/?c=8248&d=18C157aOhLNPYjFmm2KPOK4HQ5jX5s6Wj_NQEKPoyw&u=https%3a%2f%2fgithub%2ecom%2fbroadinstitute%2fSpliceAI-lookup%2fissues%2f84%23issuecomment-2475079172>, or unsubscribe<https://scanmail.trustwave.com/?c=8248&d=18C157aOhLNPYjFmm2KPOK4HQ5jX5s6Wj_ICR6e5wA&u=https%3a%2f%2fgithub%2ecom%2fnotifications%2funsubscribe-auth%2fBMYSQODVEOODT6YB5MJJE2D2APTBNAVCNFSM6AAAAABRNSOG3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGA3TSMJXGI>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
*************************************************************************************
The information contained in this message and or attachments is intended only for the
person or entity to which it is addressed and may contain confidential and/or
privileged material. Unless otherwise specified, the opinions expressed herein do not
necessarily represent those of Guy's and St Thomas' NHS Foundation Trust or
any of its subsidiaries. The information contained in this e-mail may be subject to
public disclosure under the Freedom of Information Act 2000. Unless the information
is legally exempt from disclosure, the confidentiality of this e-mail and any replies
cannot be guaranteed.
Any review, retransmission,dissemination or other use of, or taking of any action in
reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender
and delete the material from any system and destroy any copies.
We make every effort to keep our network free from viruses. However, it is your
responsibility to ensure that this e-mail and any attachments are free of viruses as
we can take no responsibility for any computer virus which might be transferred by
way of this e-mail.
*************************************************************************************
|
Thanks Huilin |
Dear Ben,
Thanks for your prompt reply
In my laptop I use
- mozilla firefox (browser)
- microsoft windows 11 family (operating system)
All best,
Alexandra
Le Jeudi, Novembre 14, 2024 01:11 CET, Ben Weisburd ***@***.***> a écrit:
Hi Alexandra, what browser and operating system are you using?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#84 (comment)", "url": "#84 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
--
Alexandra Martins, PhD, HDR
Inserm Researcher (CRHC)
Group Leader
Inserm UMR 1245 - Cancer and Brain Genomics
UFR Santé
22 Bvd Gambetta
CS 76183
76183 Rouen Cedex 1
France
phone#: + 33 (0)2 35 14 83 14
email: ***@***.***
https://www.researchgate.net/profile/Alexandra_Martins5
ORCID ID: 0000-0003-4322-8497
|
@amartins1 I have not been able to reproduce the issue in Firefox. |
Great. Thanks!
Le Mercredi, Décembre 04, 2024 15:46 CET, Ben Weisburd ***@***.***> a écrit:
Just in case it's still an issue on some browsers, I've added an option to display the table in a separate popup dialog:image.png (view on web) image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Alexandra Martins, PhD, HDR
Inserm researcher (CRHC)
Group Leader
INSERM U1245, Cancer and Brain Genomics (CBG)
UFR Santé, Univ Rouen Normandie
22 Boulevard Gambetta
76183 Rouen
France
phone# (office): + 33 0(2) 35 14 83 14
email: ***@***.***
ORCID: 0000-0003-4322-8497
|
I have a similar situation reported in the issue #67 & #69. I would like to find out how I can check if the SpliceAI scores are real or due to the technical artefact? Is there a way to check this on SpliceAI webpage?
Thanks a lot
The text was updated successfully, but these errors were encountered: