Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up of issue #67, #69 #84

Closed
HJin2024 opened this issue Nov 8, 2024 · 20 comments
Closed

follow up of issue #67, #69 #84

HJin2024 opened this issue Nov 8, 2024 · 20 comments

Comments

@HJin2024
Copy link

HJin2024 commented Nov 8, 2024

I have a similar situation reported in the issue #67 & #69. I would like to find out how I can check if the SpliceAI scores are real or due to the technical artefact? Is there a way to check this on SpliceAI webpage?
Thanks a lot

@bw2
Copy link
Collaborator

bw2 commented Nov 8, 2024

When you enter your variant, do you see the warning described in
#69 ?
image

@HJin2024
Copy link
Author

HJin2024 commented Nov 8, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 8, 2024

I was thinking of adding a table like the example in
#69 (comment)

image

Do you agree a table like this would address your question?

@HJin2024
Copy link
Author

HJin2024 commented Nov 9, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 12, 2024

I've now added this table to a popup for variants where the warning appears:

image

@HJin2024
Copy link
Author

HJin2024 commented Nov 12, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 12, 2024

It was showing cached results from before the feature was added. If you reload the page, you should see the new tables.

@HJin2024
Copy link
Author

HJin2024 commented Nov 13, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 13, 2024

Hi Huilin, yes, the table appears for any variant that has that warning.

@HJin2024
Copy link
Author

HJin2024 commented Nov 13, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 13, 2024

Also, based on additional feedback, instead of the warning icon, we now just show the exact position in the main table, along with the icon that brings up the detailed table. [example]

image

@amartins1
Copy link

amartins1 commented Nov 13, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 14, 2024

Hi Alexandra, what browser and operating system are you using?

@bw2 bw2 reopened this Nov 14, 2024
@HJin2024
Copy link
Author

HJin2024 commented Nov 14, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Nov 14, 2024

Thanks Huilin

@amartins1
Copy link

amartins1 commented Nov 14, 2024 via email

@bw2
Copy link
Collaborator

bw2 commented Dec 4, 2024

@amartins1 I have not been able to reproduce the issue in Firefox.
Let me know if it's still a problem.

@bw2
Copy link
Collaborator

bw2 commented Dec 4, 2024

Just in case it's still an issue on some browsers, I've added an option to display the table in a separate popup dialog:

image image

@bw2 bw2 closed this as completed in bb604c7 Dec 4, 2024
@amartins1
Copy link

amartins1 commented Dec 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants