Added unit test for tracked layout with unaligned reads. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdanford
added a commit
that referenced
this pull request
Jul 30, 2014
Added unit test for tracked layout with unaligned reads.
|
Thanks @fnothaft, I'll incorporate and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a failing unit test that tries to order an unaligned read on top of the ordered tracked layout. It fails with an NPE. I'm not sure what the behavior is supposed to be when dealing with unaligned reads; it seems that if we expect to not receive unaligned reads, we should check the alignment status and throw an IllegalArgumentException.