fix: Ssaluja add readiness health check #91
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfhartmann
requested changes
Nov 7, 2024
|
also you'll want to change your PR title to use https://www.conventionalcommits.org/en/v1.0.0/ once this is rebased it'll fail it's check |
added 2 commits
November 8, 2024 14:04
The sidecar container "cloud-sql-proxy" was missing a readiness health check. This commit adds the check to the YAML configuration. See [readiness health check documentation](https://github.com/GoogleCloudPlatform/cloud-sql-proxy/tree/main/examples/k8s-health-check#readiness-health-check-configuration) for more details.
pssaluja
force-pushed
the
ssaluja_add_readiness_health_check
branch
from
88d98af to
ac2af1a
Compare
tfhartmann
changed the base branch from
dependabot/terraform/deployment/dev/terraform/terraform_dev-6dd1b76ddc
to
main
added 3 commits
November 8, 2024 14:18
Follow the conventional commit guide.
lbenezriravin
changed the title
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add readiness health check for cloud-sql-proxy sidecar
The cloud-sql-proxy sidecar container was missing a readiness health
check, which helps Kubernetes manage traffic to the pod only when
the proxy is ready. This commit updates the YAML file to include the
readiness check.
For more details, see the readiness health check documentation.