Reject attempts to use hybrid Barclay/legacy syntax with the Barclay parser. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
============================================
+ Coverage 76.56% 76.61% +0.05%
- Complexity 669 671 +2
============================================
Files 26 26
Lines 2296 2301 +5
Branches 455 455
============================================
+ Hits 1758 1763 +5
Misses 366 366
Partials 172 172
Continue to review full report at Codecov.
|
lbergelson
approved these changes
Nov 6, 2018
| } | ||
| } | ||
| } | ||
|
|
||
| // Reject attempts to use hybrid Barclay/legacy syntax that contains embedded "=". Most of the time | ||
| // this works because jopt accepts "-O=value". But if "value" contains what appears to be tagging |
There was a problem hiding this comment.
Why not just use a javadoc comment? I've never really understood the prohibition on putting javadoc on private things.
There was a problem hiding this comment.
Just due to habit. Fixed.
cmnbroad
force-pushed
the
cn_fix_hybrid_syntax
branch
from
b096758 to
f8cf671
Compare
|
Thanks @lbergelson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145.