Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pom attributes, update readme to reflect new dependencies. #191

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Jan 31, 2023

Fixes the pom so Sonatype will not reject Barclay because there are missing attributes. Also update the readme with the new dependencies.

@cmnbroad cmnbroad changed the title Update readme to reflect new dependencies. Fix pom attributes, update readme to reflect new dependencies. Jan 31, 2023
@cmnbroad cmnbroad requested a review from lbergelson January 31, 2023 22:11
url 'scm:git@github.com:broadinstitute/barclay.git'
connection 'scm:git@github.com:broadinstitute/barclay.git'
developerConnection 'scm:git@github.com:broadinstitute/barclay.git'
url = 'scm:git@github.com:broadinstitute/barclay.git'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mysteries of groovy....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It never ceases to entertain.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmnbroad I feel like I was puzzled by this exact problem before and then forgot about it.

@cmnbroad cmnbroad merged commit 310d307 into master Feb 6, 2023
@cmnbroad cmnbroad deleted the cn_fix_readme branch February 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants