Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list-outputs #248
Add list-outputs #248
Changes from all commits
bb69e0a
f2c7f0d
3149dd2
b85068b
cc288c5
db2cefa
565a5b2
d02d6db
dce9ee5
8f77751
ce3297b
f29b545
d6d95c3
1cf5e6f
ce70697
0071d01
7b3b20e
200be24
388d34e
c3b87a7
5b11e49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about future-proofing us a little here: how about we classify the
in_string
?I mean classify it as a local regular path, GCS path, or Azure path, or not a path at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classification would be useful in a command like
fetch-outputs
where we need to know the classification before downloading the output. Since we're not downloading anything in this function, we'd only be interested in knowing whether its a file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the pytest parameters below, I'm using the same workflow to test different options of list-output. This runs the same workflow multiple times (redundant). I'm thinking of maybe running the workflow once, saving the workflow id in a global variable then have a different function that would run through the different list-output command