Skip to content

Commit

Permalink
Ice Lake
Browse files Browse the repository at this point in the history
  • Loading branch information
mcovarr committed Aug 27, 2024
1 parent f9fb66f commit b24f569
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ object GcpBatchRuntimeAttributes {
private val cpuPlatformValidationInstance = new StringRuntimeAttributesValidation(CpuPlatformKey).optional
// via `gcloud compute zones describe us-central1-a`
val CpuPlatformIntelCascadeLakeValue = "Intel Cascade Lake"
val CpuPlatformIntelIceLakeValue = "Intel Ice Lake"
val CpuPlatformAMDRomeValue = "AMD Rome"

val UseDockerImageCacheKey = "useDockerImageCache"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ object GcpBatchMachineConstraints {
if (googleLegacyMachineSelection) {
s"predefined-$cpu-${memory.to(MemoryUnit.MB).amount.intValue()}"
} else {
// If someone requests Intel Cascade Lake as their CPU platform then switch the machine type to n2.
// If someone requests Intel Cascade Lake or Intel Ice Lake as their CPU platform then switch the machine type to n2.
// Similarly, CPU platform of AMD Rome corresponds to the machine type n2d.
val customMachineType =
cpuPlatformOption match {
case Some(GcpBatchRuntimeAttributes.CpuPlatformIntelCascadeLakeValue) => N2CustomMachineType
case Some(GcpBatchRuntimeAttributes.CpuPlatformIntelIceLakeValue) => N2CustomMachineType
case Some(GcpBatchRuntimeAttributes.CpuPlatformAMDRomeValue) => N2DCustomMachineType
case _ => N1CustomMachineType
}
Expand Down

0 comments on commit b24f569

Please sign in to comment.