-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS-EFS postmapping fix #5522
AWS-EFS postmapping fix #5522
Conversation
Hi, |
Hi, |
hi @nvanaja - we discussed this internally and there was some thought that this PR might possibly be unnecessary now with the changes in Cromwell 52 (especially PRs #5468 and #5554). Would you mind confirming that this change is still needed - and if so we'll look to have it reviewed as part of our current sprint? Thanks! |
Hi @cjllanwarne Thanks for the update. I looked at #5468 and #5554 changes made. They all S3 related changes/enghancements. This fix is EFS specific and hence not addressed by the above two. So this change is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a code perspective. Would be good to see if the Cromwell team can support Centaur tests with this configuration. This would presumably require a different environment from the current AWS test environment which uses S3 rather than EFS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nvanaja. Please revert file permissions change for backend/src/main/scala/cromwell/backend/standard/StandardAsyncExecutionActor.scala
Done. |
Added AWS-EFS expression post mapping function so the output expressions with files with relative paths get mapped to the correct path.