Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron run integrations each day of the week #7089

Merged
merged 31 commits into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e0cced3
Add cron run integrations each day of the week
kraefrei Mar 10, 2023
8c4ed38
Reuse integration test workflow to setup custom slack integration
kraefrei Mar 10, 2023
fd10d3a
Update for branch argument
kraefrei Mar 10, 2023
008ca09
Checkout repo for action
kraefrei Mar 10, 2023
de08801
Fix reused workflow
kraefrei Mar 10, 2023
a0dc1ad
Fix whitespace
kraefrei Mar 10, 2023
b5da7bb
Merge steps for job
kraefrei Mar 10, 2023
00b95e5
Use conditional logic to enable slack alerts
kraefrei Mar 14, 2023
7a3ce3b
Fix sub workflow so it is not a step
kraefrei Mar 14, 2023
2649e68
Fix types
kraefrei Mar 14, 2023
8df4ddc
Move inputs
kraefrei Mar 14, 2023
e0c7072
Change type of inputs
kraefrei Mar 14, 2023
8b6ea57
Move types
kraefrei Mar 14, 2023
7e9edf4
Add secrets for linter
kraefrei Mar 14, 2023
082f3d6
Fix whitespace
kraefrei Mar 14, 2023
b03e2f6
Adjust whitespace
kraefrei Mar 14, 2023
1cb58dd
Fix boolean, and if expression
kraefrei Mar 15, 2023
d23a85e
target branch arge adjusted
kraefrei Mar 15, 2023
9dbe06b
fix args
kraefrei Mar 15, 2023
0b02497
Adjust nightly workflow using linter
kraefrei Mar 15, 2023
60db1a5
One more test of the nightly
kraefrei Mar 15, 2023
e6e8312
Move comment to try to retest
kraefrei Mar 16, 2023
a4bcdc7
Add push trigger
kraefrei Mar 16, 2023
a3c2294
exit 1
kraefrei Mar 16, 2023
ef0c0c3
move tag
kraefrei Mar 16, 2023
b274462
change boolean to string
kraefrei Mar 16, 2023
90cc46d
remove exit 1
kraefrei Mar 16, 2023
9387c5b
Test slack with successes
kraefrei Mar 16, 2023
f82e2a3
Final adjustments
kraefrei Mar 16, 2023
72df3c8
remove push
kraefrei Mar 16, 2023
b264add
Merge branch 'develop' into WX-907
kraefrei Mar 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,43 @@ name: 'Integration Tests'

#This github action runs all of Cromwell's integration tests.

#This is what shows up in the github workflows page as the title.
#This is what shows up in the github workflows page as the title.
run-name: ${{ github.actor }} Integration Testing.

#What will trigger the workflow to run.
#What will trigger the workflow to run.
on:
workflow_call:
inputs:
target-branch:
description: 'The branch to run integration tests against'
required: false
type: string
slack-alert:
description: 'A flag to enable slack alerts. True if this should alert via slack'
required: true
default: false
type: boolean
secrets:
VAULT_ROLE_ID_CI:
required: true
VAULT_SECRET_ID_CI:
required: true
BROADBOT_GITHUB_TOKEN:
required: true
SLACK_WEBHOOK_URL:
required: false
workflow_dispatch: #Manual trigger from GitHub UI
push: #git push
merge_group:

permissions:
permissions:
contents: read

jobs:
integration-tests:
strategy:
fail-fast: false #disabling fail-fast means that even if one test fails, the others will still try to complete.
#Each entry below is a single integration test that lives in /src/ci/bin/.
#Each entry below is a single integration test that lives in /src/ci/bin/.
#Each will be launched on its own runner so they can occur in parallel.
#Friendly names are displayed on the Github UI and aren't used anywhere else.
matrix:
Expand Down Expand Up @@ -76,6 +96,8 @@ jobs:
timeout-minutes: 120
steps:
- uses: actions/checkout@v3 # checkout the cromwell repo
with:
ref: ${{ inputs.target-branch }}
- uses: ./.github/set_up_cromwell_action #This github action will set up git-secrets, caching, java, and sbt.
with:
cromwell_repo_token: ${{ secrets.BROADBOT_GITHUB_TOKEN }}
Expand All @@ -87,8 +109,15 @@ jobs:
set -e
echo Running test.sh
./src/ci/bin/test.sh
- uses: ravsamhq/notify-slack-action@v2
if: inputs.slack-alert
with:
status: ${{ job.status }}
notify_when: "failure"
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
#The "shell: ..."" line is a way to force the Github Action Runner to use a bash shell that thinks it has a TTY.
#The issue and solution are described here: https://github.com/actions/runner/issues/241#issuecomment-842566950
#This is only needed for ReferenceDiskManifestBuilderApp test.
#This is only needed for ReferenceDiskManifestBuilderApp test.
#This test uses fancy colors in the output, which likely causes the problem.
#See WX-938.
#See WX-938.
23 changes: 23 additions & 0 deletions .github/workflows/nightly_integration_tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#This github action runs all of Cromwell's integration tests nightly.
name: 'Nightly Integration Tests'

#This is what shows up in the github workflows page as the title.
run-name: Nightly ${{ github.actor }} Integration Testing.

#What will trigger the workflow to run.
on:
workflow_dispatch:
schedule:
- cron: '0 0 * * 1-5'

permissions:
contents: read

# Use if as arg to only send slack notifications on nightly
jobs:
integration-tests:
uses: broadinstitute/cromwell/.github/workflows/integration_tests.yml@develop
with:
target-branch: 'develop'
slack-alert: true
secrets: inherit