Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WX-1260] Acquire sas token from task runner #7241
[WX-1260] Acquire sas token from task runner #7241
Changes from 35 commits
67070f6
d33dad3
34d63e5
0d279eb
06531d7
aa1bc52
8d3a2e7
678f05c
9991e5a
8cad15b
408e008
05cab44
e04f175
05d3991
045835b
f37ee7a
75ca3ea
5b6852c
f1e9ea7
4c4b92a
9c9a293
b1699d5
96e7d7d
3153345
f958150
4146ac1
d84f847
f694f65
8e05ca0
a62307a
e7cd74c
510aa31
b5e3c37
7f9044e
e227bb1
5293997
60f999b
c519f58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 184 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L184
Check warning on line 191 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L191
Check warning on line 212 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L209-L212
Check warning on line 216 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L214-L216
Check warning on line 221 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L218-L221
Check warning on line 230 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L228-L230
Check warning on line 236 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L235-L236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ToL] This could be a case where a default in the parameter list makes more sense than
Option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I missed this in my review, good catch. Rather than either of those, I think we want to pass NO duration through to WSM if this method's caller doesn't specify one, so we use the WSM default rather than setting our own.
Check warning on line 248 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L247-L248
Check warning on line 254 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobFileSystemManager.scala#L250-L254
Check warning on line 189 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala#L189
Check warning on line 44 in filesystems/blob/src/main/scala/cromwell/filesystems/blob/WorkspaceManagerApiClientProvider.scala
Codecov / codecov/patch
filesystems/blob/src/main/scala/cromwell/filesystems/blob/WorkspaceManagerApiClientProvider.scala#L44
Check warning on line 670 in supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/actors/GcpBatchAsyncBackendJobExecutionActor.scala
Codecov / codecov/patch
supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/actors/GcpBatchAsyncBackendJobExecutionActor.scala#L670