WX-1595 Port more tests from papi-common to the GCP Batch backend #7413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexITC
commented
Apr 26, 2024
| @@ -46,6 +46,7 @@ case class GcpBatchWorkflowPaths(workflowDescriptor: BackendWorkflowDescriptor, | |||
|
|
|||
| private val workflowOptions: WorkflowOptions = workflowDescriptor.workflowOptions | |||
|
|
|||
| // TODO: Do we actually need this? it seems to be used only by tests | |||
There was a problem hiding this comment.
I wonder if anyone can comment on this, this method seems unnecessary because its only used by the tests, the same occurs in PAPI.
There was a problem hiding this comment.
Looks like completely dead code in Batch, fine to remove IMO. IntelliJ doesn't even find any references in tests.
There was a problem hiding this comment.
Yes, I skipped porting these tests but I wanted to double check before removing the code.
Thanks for looking into it.
aednichols
approved these changes
May 14, 2024
| @@ -46,6 +46,7 @@ case class GcpBatchWorkflowPaths(workflowDescriptor: BackendWorkflowDescriptor, | |||
|
|
|||
| private val workflowOptions: WorkflowOptions = workflowDescriptor.workflowOptions | |||
|
|
|||
| // TODO: Do we actually need this? it seems to be used only by tests | |||
There was a problem hiding this comment.
Looks like completely dead code in Batch, fine to remove IMO. IntelliJ doesn't even find any references in tests.
aednichols
changed the title
rsaperst
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #7410