Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1625 Refactor ahead of quota retry #7432

Merged
merged 9 commits into from
May 15, 2024
Merged

WX-1625 Refactor ahead of quota retry #7432

merged 9 commits into from
May 15, 2024

Conversation

aednichols
Copy link
Collaborator

While trying to figure out where to put quota retry, I made some changes to StandardAsyncExecutionActor to help wrap my head around it.

We probably ultimately want quota retried in PipelinesApiAsyncBackendJobExecutionActor, but I think the refactor is worth checking in so the next person has an easier time.

I also included a preparatory refactor that makes isQuotaMessage available at the appropriate scope for use in the next PR, so it'll be smaller.

@aednichols aednichols requested a review from a team as a code owner May 13, 2024 21:19
@THWiseman
Copy link
Contributor

LGTM, excellent cleanup + clarity.

@aednichols aednichols enabled auto-merge (squash) May 15, 2024 19:45
@aednichols aednichols merged commit 0e21d72 into develop May 15, 2024
34 checks passed
@aednichols aednichols deleted the aen_wx_1625_4 branch May 15, 2024 20:59
@aednichols aednichols mentioned this pull request May 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants