[WX-1792] Emit Cost Per Hour #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute/cromwell into jgd_WX-1784_realCostResponse
…ute/cromwell into jgd_WX-1784_realCostResponse
…e/cromwell into WX-1792-emit-cost-per-hour
aednichols
approved these changes
Oct 2, 2024
Comment on lines
+90
to
+96
| /* | ||
| The cost catalog is annoyingly inconsistent and unstructured in this area. | ||
| - For N1 machines, only predefined SKUs are included, and they have "Predefined" in their description strings. | ||
| We will eventually fall back to using these SKUs for custom machines, but accurately represent them as Predefined here. | ||
| - For non-N1 machines, both custom and predefined SKUs are included, custom ones include "Custom" in their description | ||
| strings and predefined SKUs are only identifiable by the absence of "Custom." | ||
| */ |
There was a problem hiding this comment.
This is so annoying. Definitely appreciate the comment!
|
This remains ready for review, but I haven't been able to do the scale testing I planned because there's a change needed to get the auth to GCP working in Terra deployments. Planning to take care of that and do the scale testing before merging this. |
salonishah11
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates
vmCostPerHourmetadata records for PAPIv2beta workflow tasks. Currently this cost includes only RAM and CPU, not GPU, disks, etc.Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes