DSM-commented-out-unreliable-assertion #2023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found two things that are worth attention:
1382486400000 -> Wed Oct 23 2013 04:00:00 GMT+0400 (Georgia Standard Time)
) from thenew Date().getTime()
function (The reason why the Submission manager unit test fails)Here is the solution for the failing test (2):
It would be better to remove the test based on the
new Date()
class (that fails occasionally).It seems the JS Date class is not always predictable:
Dates in JavaScript are Broken. Who Shall Fix them
Inconsistent Date.prototype.getTime() value across different Node.js versions
Mocking Date.now() doesn't work on CircleCI
Failed test (CircleCi) - Please check the
tmp/junit/test-results.xml
file, where you can search for "START_TIME" and "END_TIME" and check that they both equal to - > 1382486400000