Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test infrastructure for framework users #2033

Closed
magicDGS opened this issue Jul 22, 2016 · 1 comment
Closed

Test infrastructure for framework users #2033

magicDGS opened this issue Jul 22, 2016 · 1 comment

Comments

@magicDGS
Copy link
Contributor

I'm using GATK4 as a framework to implement my own tools, and it will be nice to have a way of perform integration tests using IntegrationTestSpec. Nevertheless, it requires the extension of the CommandLineProgramTest to run the command, and thus it is extending BaseTest.

The issues that this infrastructure generates when trying to use this test classes are the following:

  • BaseTest loading of GenomeLocParser is annotated with @BeforeClass, which throws an error because the reference genome (hg19MiniReference) is not present in the repository.
  • CommandLineProgramTest is using org.broadinstitute.hellbender.Main for running the commands, but for custom tools the instanceMain with a different list of packages. Although this could be solved by extending the class by another abstract class.

I propose (and I can implemented if you agree) the following:

  • CommandLineProgramTest not implementing BaseTest.
  • CommandLineProgramTest as a real abstract class without implementations of getTestDataDir() or runCommandLine()
  • Abstract GATKCommandLineProgramTest extending both CommandLineProgramTest and BaseTest, sited in org.broadinstitute.hellbender.utils.test and used in all integrations tests in this repository and the protected repository.
magicDGS added a commit to bioinformagik/gatk that referenced this issue Aug 26, 2016
@magicDGS
Copy link
Contributor Author

magicDGS commented Sep 8, 2016

Related with #2125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant