Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funcotator - COSMIC data for overlapping mutations should list protein changes #4400

Closed
jonn-smith opened this issue Feb 13, 2018 · 5 comments
Assignees

Comments

@jonn-smith
Copy link
Collaborator

Currently the COSMIC_overlapping_mutations field produces only a count, rather than a count for each protein change.

It should look like this:

p.L858R(1489)| p.L858Q(1)| p.L858K(1)

@jonn-smith jonn-smith self-assigned this Feb 13, 2018
@jonn-smith
Copy link
Collaborator Author

Need to investigate if COSMIC has transcript information to make these annotations correct.

At a minimum can just duplicate Oncotator functionality here.

@jonn-smith
Copy link
Collaborator Author

jonn-smith commented Mar 26, 2018

Before anything else, check to see if this is really a beta blocker.

Check with @LeeTL1220 to see what Oncotator does for this case.

@jonn-smith
Copy link
Collaborator Author

From Lee:

he COSMIC datasource in oncotator simply finds all overlapping records and counts the protein change ("Mutation AA") values. Like a histogram of all overlapping records. (edited)

mutation_AAs = collections.Counter([entry['Mutation AA'] for entry in overlapping_cosmic_entries])

@jonn-smith
Copy link
Collaborator Author

jonn-smith commented Sep 11, 2018

Looks like COSMIC should contain all the needed info to create this annotation properly. Will adjust LOE for this issue (7->2)

@jonn-smith
Copy link
Collaborator Author

@LeeTL1220 Should the default funcotation here be an empty string, or "0"? Currently it's the latter, but with this update it seems that with this change we should switch to empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants