Removed check in PrintReadsSpark for coordinate sorted bam #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
===============================================
+ Coverage 80.421% 80.427% +0.006%
- Complexity 17820 17821 +1
===============================================
Files 1089 1089
Lines 64161 64159 -2
Branches 10344 10344
===============================================
+ Hits 51599 51601 +2
+ Misses 8501 8497 -4
Partials 4061 4061
|
lbergelson
requested changes
Jun 6, 2018
There was a problem hiding this comment.
@jamesemery This seems sane to me. 👍 after the slight test update, and the previous branch going.
| @@ -170,7 +170,7 @@ public void testSequenceDictionaryValidation() throws Exception { | |||
| }; | |||
| } | |||
|
|
|||
| @Test(dataProvider="testFileToFile_queryNameSorted", expectedExceptions = UserException.class, groups="spark") | |||
| @Test(dataProvider="testFileToFile_queryNameSorted", groups="spark") | |||
| public void testFileToFile_queryNameSorted(String fileIn, String extOut, String reference) throws Exception { | |||
There was a problem hiding this comment.
Could you add assertions to these tests that the input file actually claims to be queryname sorted? It's sort of stupid, but it's better to never trust anything..
jamesemery
force-pushed
the
je_selectReadsSpark
branch
from
9d2dd45 to
7b2fdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4545
Fixes #4818