Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XsvTableFeatures now always put out the right number of columns. #4915

Merged

Conversation

jonn-smith
Copy link
Collaborator

Fixes #4193

XsvTableFeature no longer removes an extra column if start and end in
the config file for a LocatableXsv data source are the same.

`XsvTableFeature` no longer removes an extra column if start and end in
the config file for a `LocatableXsv` data source are the same.
Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the git lfs is committing properly? Usually, I do not see the actual contents in the PR. If this is a false alarm, merge away.

@jonn-smith
Copy link
Collaborator Author

Yeah - the files I needed are all in there and the tests that rely on them pass.

Merging...

@codecov-io
Copy link

Codecov Report

Merging #4915 into master will decrease coverage by 0.004%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #4915       +/-   ##
===============================================
- Coverage     80.459%   80.455%   -0.004%     
+ Complexity     17839     17838        -1     
===============================================
  Files           1092      1092               
  Lines          64240     64242        +2     
  Branches       10350     10351        +1     
===============================================
- Hits           51687     51686        -1     
- Misses          8502      8505        +3     
  Partials        4051      4051
Impacted Files Coverage Δ Complexity Δ
...tils/codecs/xsvLocatableTable/XsvTableFeature.java 56.716% <100%> (+1.332%) 17 <0> (+1) ⬆️
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)

@jonn-smith jonn-smith merged commit 0370bdd into master Jun 19, 2018
@jonn-smith jonn-smith deleted the jts_funcotator_xsv_locatable_double_column_removal_4913 branch June 19, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants