-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an edge case bug in PalindromeArtifactReadTransformer #5038
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5038 +/- ##
==============================================
+ Coverage 86.38% 86.469% +0.088%
- Complexity 28640 29108 +468
==============================================
Files 1782 1782
Lines 132603 134161 +1558
Branches 14761 15067 +306
==============================================
+ Hits 114543 116007 +1464
- Misses 12740 12805 +65
- Partials 5320 5349 +29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! In a perfect world it would be great to have a new test, but I did run this branch on my data and it works. 👍
@meganshand Do you have a public mitochondrial bam that I could use for a test? If not, what if I took just the reads at the beginning of the contig, excluding any variants, and anonymized the header? That would be enough. Actually, if you do have an entire mitochondrial bam that's public, I wouldn't mind adding a mitochondrial integration test to the repo. . . |
@davidbenjamin I do have a public bam! This is just chrM for NA12878: The coverage should be quite high, so if it's too big I can downsample it if you want. And my mitochondria only reference would probably also be useful: |
@meganshand I will include testing for this bug as part of an overall mitochondria integration test using your NA12878 bam in a separate PR. |
Closes #5036.
@meganshand This fixes the bug you found.